Merge pull request #175 from 2OOP/166-audiomanager-opslitsen-om-single-responsibility-principle-te-volgen

166 audiomanager opslitsen om single responsibility principle te volgen Done

app/pom.xml

@@ -149,11 +149,12 @@
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
                         <arg>
                             -Xplugin:ErrorProne \
-                            -Xep:RestrictedApi:ERROR \
-                            -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-                            -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-                            -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
                         </arg>
+						<!--						TODO-->
+						<!--						-Xep:RestrictedApi:ERROR \-->
+						<!--						-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
+						<!--						-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
+						<!--						-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
                         <arg>-XDcompilePolicy=simple</arg>
                         <arg>--should-stop=ifError=FLOW</arg>
                     </compilerArgs>

framework/pom.xml

@@ -161,12 +161,13 @@
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
                         <arg>
-                            -Xplugin:ErrorProne \
+                            -Xplugin:ErrorProne
-                            -Xep:RestrictedApi:ERROR \
-                            -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-                            -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-                            -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
                         </arg>
+<!--						TODO-->
+<!--						-Xep:RestrictedApi:ERROR \-->
+<!--						-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
+<!--						-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
+<!--						-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
                         <arg>-XDcompilePolicy=simple</arg>
                         <arg>--should-stop=ifError=FLOW</arg>
                     </compilerArgs>

framework/src/main/java/org/toop/framework/audio/MusicManager.java

@@ -2,8 +2,9 @@ package org.toop.framework.audio;
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.toop.framework.dispatch.interfaces.Dispatcher;
+import org.toop.framework.dispatch.JavaFXDispatcher;
 import org.toop.framework.annotations.TestsOnly;
-import org.toop.framework.audio.interfaces.Dispatcher;
 import org.toop.framework.resource.ResourceManager;
 import org.toop.framework.resource.resources.BaseResource;
 import org.toop.framework.resource.types.AudioResource;

framework/src/main/java/org/toop/framework/audio/interfaces/Dispatcher.java

@@ -1,6 +0,0 @@
-package org.toop.framework.audio.interfaces;
-
-// TODO isn't specific to audio
-public interface Dispatcher {
-    void run(Runnable task);
-}

framework/src/main/java/org/toop/framework/dispatch/JavaFXDispatcher.java

@@ -1,9 +1,8 @@
-package org.toop.framework.audio;
+package org.toop.framework.dispatch;
 
 import javafx.application.Platform;
-import org.toop.framework.audio.interfaces.Dispatcher;
+import org.toop.framework.dispatch.interfaces.Dispatcher;
 
-// TODO isn't specific to audio
 public class JavaFXDispatcher implements Dispatcher {
     @Override
     public void run(Runnable task) {

framework/src/main/java/org/toop/framework/dispatch/interfaces/Dispatcher.java

@@ -0,0 +1,5 @@
+package org.toop.framework.dispatch.interfaces;
+
+public interface Dispatcher {
+    void run(Runnable task);
+}

framework/src/test/java/org/toop/framework/audio/MusicManagerTest.java

@@ -2,7 +2,7 @@ package org.toop.framework.audio;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.toop.framework.audio.interfaces.Dispatcher;
+import org.toop.framework.dispatch.interfaces.Dispatcher;
 import org.toop.framework.resource.resources.BaseResource;
 import org.toop.framework.resource.types.AudioResource;
 

game/pom.xml

@@ -123,12 +123,13 @@
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
                         <arg>
-                            -Xplugin:ErrorProne \
+                            -Xplugin:ErrorProne
-                            -Xep:RestrictedApi:ERROR \
-                            -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-                            -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-                            -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
                         </arg>
+						<!--						TODO-->
+						<!--						-Xep:RestrictedApi:ERROR \-->
+						<!--						-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
+						<!--						-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
+						<!--						-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
                         <arg>-XDcompilePolicy=simple</arg>
                         <arg>--should-stop=ifError=FLOW</arg>
                     </compilerArgs>

pom.xml

@@ -131,12 +131,13 @@
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
                         <arg>
-                            -Xplugin:ErrorProne \
+                            -Xplugin:ErrorProne
-                            -Xep:RestrictedApi:ERROR \
-                            -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-                            -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-                            -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
                         </arg>
+						<!--						TODO-->
+						<!--						-Xep:RestrictedApi:ERROR \-->
+						<!--						-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
+						<!--						-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
+						<!--						-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
                         <arg>-XDcompilePolicy=simple</arg>
                         <arg>--should-stop=ifError=FLOW</arg>
                     </compilerArgs>