stef_buwalda/pism
1
0
Fork 0
mirror of https://github.com/2OOP/pism.git synced 2026-02-04 10:54:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #175 from 2OOP/166-audiomanager-opslitsen-om-single-responsibility-principle-te-volgen

Browse Source 
166 audiomanager opslitsen om single responsibility principle te volgen Done
This commit is contained in:
Bas Antonius de Jong
2025-10-12 20:44:57 +02:00
committed by GitHub
parent 5317c42c81 bab11b64a5
commit 00daf37244
9 changed files with 33 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/pom.xml
View File

@@ -149,11 +149,12 @@
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
<arg>
-Xplugin:ErrorProne \
-Xep:RestrictedApi:ERROR \
-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
</arg>
<!-- TODO-->
<!-- -Xep:RestrictedApi:ERROR \-->
<!-- -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
<!-- -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
<!-- -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
<arg>-XDcompilePolicy=simple</arg>
<arg>--should-stop=ifError=FLOW</arg>
</compilerArgs>

11
framework/pom.xml
View File

@@ -161,12 +161,13 @@
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
<arg>
-Xplugin:ErrorProne \
-Xep:RestrictedApi:ERROR \
-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
-Xplugin:ErrorProne
</arg>
<!-- TODO-->
<!-- -Xep:RestrictedApi:ERROR \-->
<!-- -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
<!-- -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
<!-- -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
<arg>-XDcompilePolicy=simple</arg>
<arg>--should-stop=ifError=FLOW</arg>
</compilerArgs>

3
framework/src/main/java/org/toop/framework/audio/MusicManager.java
View File

@@ -2,8 +2,9 @@ package org.toop.framework.audio;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.toop.framework.dispatch.interfaces.Dispatcher;
import org.toop.framework.dispatch.JavaFXDispatcher;
import org.toop.framework.annotations.TestsOnly;
import org.toop.framework.audio.interfaces.Dispatcher;
import org.toop.framework.resource.ResourceManager;
import org.toop.framework.resource.resources.BaseResource;
import org.toop.framework.resource.types.AudioResource;

6
framework/src/main/java/org/toop/framework/audio/interfaces/Dispatcher.java
View File

@@ -1,6 +0,0 @@
package org.toop.framework.audio.interfaces;
// TODO isn't specific to audio
public interface Dispatcher {
void run(Runnable task);
}

5
framework/src/main/java/org/toop/framework/audio/JavaFXDispatcher.java → framework/src/main/java/org/toop/framework/dispatch/JavaFXDispatcher.java
View File

@@ -1,9 +1,8 @@
package org.toop.framework.audio;
package org.toop.framework.dispatch;
import javafx.application.Platform;
import org.toop.framework.audio.interfaces.Dispatcher;
import org.toop.framework.dispatch.interfaces.Dispatcher;
// TODO isn't specific to audio
public class JavaFXDispatcher implements Dispatcher {
@Override
public void run(Runnable task) {

5
framework/src/main/java/org/toop/framework/dispatch/interfaces/Dispatcher.java Normal file
View File

@@ -0,0 +1,5 @@
package org.toop.framework.dispatch.interfaces;
public interface Dispatcher {
void run(Runnable task);
}

2
framework/src/test/java/org/toop/framework/audio/MusicManagerTest.java
View File

@@ -2,7 +2,7 @@ package org.toop.framework.audio;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.toop.framework.audio.interfaces.Dispatcher;
import org.toop.framework.dispatch.interfaces.Dispatcher;
import org.toop.framework.resource.resources.BaseResource;
import org.toop.framework.resource.types.AudioResource;

11
game/pom.xml
View File

@@ -123,12 +123,13 @@
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
<arg>
-Xplugin:ErrorProne \
-Xep:RestrictedApi:ERROR \
-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
-Xplugin:ErrorProne
</arg>
<!-- TODO-->
<!-- -Xep:RestrictedApi:ERROR \-->
<!-- -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
<!-- -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
<!-- -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
<arg>-XDcompilePolicy=simple</arg>
<arg>--should-stop=ifError=FLOW</arg>
</compilerArgs>

11
pom.xml
View File

@@ -131,12 +131,13 @@
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
<arg>
-Xplugin:ErrorProne \
-Xep:RestrictedApi:ERROR \
-XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \
-XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \
-XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.
-Xplugin:ErrorProne
</arg>
<!-- TODO-->
<!-- -Xep:RestrictedApi:ERROR \-->
<!-- -XepOpt:RestrictedApi:annotation=org.toop.framework.annotations.TestsOnly \-->
<!-- -XepOpt:RestrictedApi:allowlistRegex=(?s).*/src/test/java/.*|.*test\.java \-->
<!-- -XepOpt:RestrictedApi:message=This API is marked @TestsOnly and shouldn't be normally used.-->
<arg>-XDcompilePolicy=simple</arg>
<arg>--should-stop=ifError=FLOW</arg>
</compilerArgs>