From 3fde9f5a6488f2580d38cc195ee5dd53af75cfe1 Mon Sep 17 00:00:00 2001
From: michiel <m.brands.3@st.hanze.nl>
Date: Thu, 18 Sep 2025 12:46:16 +0200
Subject: [PATCH] new unit tests + a small improvement to the ai where it didnt
 instantly block during unit tests

---
 .idea/misc.xml                                |   2 +-
 .idea/workspace.xml                           |  79 +++++-----
 .../toop/game/tictactoe/MinMaxTicTacToe.java  |  41 ++++--
 src/test/java/MinMaxTicTacToeTest.java        | 135 +++++++++++-------
 4 files changed, 164 insertions(+), 93 deletions(-)

diff --git a/.idea/misc.xml b/.idea/misc.xml
index 1c92083..1572df4 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -8,7 +8,7 @@
       </list>
     </option>
   </component>
-  <component name="ProjectRootManager" version="2" languageLevel="JDK_25" default="true" project-jdk-name="openjdk-ea-25" project-jdk-type="JavaSDK">
+  <component name="ProjectRootManager" version="2" languageLevel="JDK_24" project-jdk-name="openjdk-ea-25" project-jdk-type="JavaSDK">
     <output url="file://$PROJECT_DIR$/out" />
   </component>
 </project>
\ No newline at end of file
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index 2d7ff3e..1b770d6 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -4,10 +4,11 @@
     <option name="autoReloadType" value="SELECTIVE" />
   </component>
   <component name="ChangeListManager">
-    <list default="true" id="997b32da-b4d4-48ac-ab51-52d65f364f81" name="Changes" comment="">
-      <change beforePath="$PROJECT_DIR$/.idea/compiler.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/compiler.xml" afterDir="false" />
+    <list default="true" id="997b32da-b4d4-48ac-ab51-52d65f364f81" name="Changes" comment="nog een kleine fix waarbij die depth van 8 gebruikte in plaats van game.movesleft">
+      <change beforePath="$PROJECT_DIR$/.idea/misc.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/misc.xml" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/src/main/java/org/toop/game/tictactoe/MinMaxTicTacToe.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/org/toop/game/tictactoe/MinMaxTicTacToe.java" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/test/java/MinMaxTicTacToeTest.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/test/java/MinMaxTicTacToeTest.java" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -35,12 +36,12 @@
     &quot;assignee&quot;: &quot;BAFGdeJong&quot;
   }
 }</component>
-  <component name="GithubPullRequestsUISettings">{
-  &quot;selectedUrlAndAccountId&quot;: {
-    &quot;url&quot;: &quot;git@github.com:2OOP/pism_ttt.git&quot;,
-    &quot;accountId&quot;: &quot;7694f583-f911-4763-8185-8ea3ed608804&quot;
+  <component name="GithubPullRequestsUISettings"><![CDATA[{
+  "selectedUrlAndAccountId": {
+    "url": "https://github.com/2OOP/pism_ttt.git",
+    "accountId": "a9609b60-3227-4092-a6d9-591cac75179d"
   }
-}</component>
+}]]></component>
   <component name="MavenImportPreferences">
     <option name="explicitlyEnabledProfiles" value="lwjgl-natives-macos-aarch64,lwjgl-natives-linux-amd64" />
   </component>
@@ -56,27 +57,28 @@
     <option name="hideEmptyMiddlePackages" value="true" />
     <option name="showLibraryContents" value="true" />
   </component>
-  <component name="PropertiesComponent">{
-  &quot;keyToString&quot;: {
-    &quot;Application.Main.executor&quot;: &quot;Run&quot;,
-    &quot;JUnit.MinMaxTicTacToeTest.executor&quot;: &quot;Run&quot;,
-    &quot;ModuleVcsDetector.initialDetectionPerformed&quot;: &quot;true&quot;,
-    &quot;RunOnceActivity.ShowReadmeOnStart&quot;: &quot;true&quot;,
-    &quot;RunOnceActivity.TerminalTabsStorage.copyFrom.TerminalArrangementManager&quot;: &quot;true&quot;,
-    &quot;RunOnceActivity.git.unshallow&quot;: &quot;true&quot;,
-    &quot;git-widget-placeholder&quot;: &quot;Michiel&quot;,
-    &quot;node.js.detected.package.eslint&quot;: &quot;true&quot;,
-    &quot;node.js.detected.package.tslint&quot;: &quot;true&quot;,
-    &quot;node.js.selected.package.eslint&quot;: &quot;(autodetect)&quot;,
-    &quot;node.js.selected.package.tslint&quot;: &quot;(autodetect)&quot;,
-    &quot;nodejs_package_manager_path&quot;: &quot;npm&quot;,
-    &quot;project.structure.last.edited&quot;: &quot;Modules&quot;,
-    &quot;project.structure.proportion&quot;: &quot;0.0&quot;,
-    &quot;project.structure.side.proportion&quot;: &quot;0.0&quot;,
-    &quot;settings.editor.selected.configurable&quot;: &quot;reference.settings.project.statistic.project.settings&quot;,
-    &quot;vue.rearranger.settings.migration&quot;: &quot;true&quot;
+  <component name="PropertiesComponent"><![CDATA[{
+  "keyToString": {
+    "Application.Main.executor": "Run",
+    "JUnit.MinMaxTicTacToeTest.executor": "Run",
+    "ModuleVcsDetector.initialDetectionPerformed": "true",
+    "RunOnceActivity.ShowReadmeOnStart": "true",
+    "RunOnceActivity.TerminalTabsStorage.copyFrom.TerminalArrangementManager": "true",
+    "RunOnceActivity.git.unshallow": "true",
+    "git-widget-placeholder": "Michiel",
+    "kotlin-language-version-configured": "true",
+    "node.js.detected.package.eslint": "true",
+    "node.js.detected.package.tslint": "true",
+    "node.js.selected.package.eslint": "(autodetect)",
+    "node.js.selected.package.tslint": "(autodetect)",
+    "nodejs_package_manager_path": "npm",
+    "project.structure.last.edited": "Modules",
+    "project.structure.proportion": "0.0",
+    "project.structure.side.proportion": "0.0",
+    "settings.editor.selected.configurable": "reference.settings.project.statistic.project.settings",
+    "vue.rearranger.settings.migration": "true"
   }
-}</component>
+}]]></component>
   <component name="RunManager">
     <configuration name="Main" type="Application" factoryName="Application" nameIsGenerated="true">
       <option name="MAIN_CLASS_NAME" value="org.toop.Main" />
@@ -92,14 +94,6 @@
       </method>
     </configuration>
   </component>
-  <component name="SharedIndexes">
-    <attachedChunks>
-      <set>
-        <option value="bundled-jdk-9823dce3aa75-fbdcb00ec9e3-intellij.indexing.shared.core-IU-251.26927.53" />
-        <option value="bundled-js-predefined-d6986cc7102b-09060db00ec0-JavaScript-IU-251.26927.53" />
-      </set>
-    </attachedChunks>
-  </component>
   <component name="TaskManager">
     <task active="true" id="Default" summary="Default task">
       <changelist id="997b32da-b4d4-48ac-ab51-52d65f364f81" name="Changes" comment="" />
@@ -114,6 +108,21 @@
   <component name="TypeScriptGeneratedFilesManager">
     <option name="version" value="3" />
   </component>
+  <component name="Vcs.Log.Tabs.Properties">
+    <option name="TAB_STATES">
+      <map>
+        <entry key="MAIN">
+          <value>
+            <State />
+          </value>
+        </entry>
+      </map>
+    </option>
+  </component>
+  <component name="VcsManagerConfiguration">
+    <MESSAGE value="nog een kleine fix waarbij die depth van 8 gebruikte in plaats van game.movesleft" />
+    <option name="LAST_COMMIT_MESSAGE" value="nog een kleine fix waarbij die depth van 8 gebruikte in plaats van game.movesleft" />
+  </component>
   <component name="XSLT-Support.FileAssociations.UIState">
     <expand />
     <select />
diff --git a/src/main/java/org/toop/game/tictactoe/MinMaxTicTacToe.java b/src/main/java/org/toop/game/tictactoe/MinMaxTicTacToe.java
index 03ae6f0..1fd2383 100644
--- a/src/main/java/org/toop/game/tictactoe/MinMaxTicTacToe.java
+++ b/src/main/java/org/toop/game/tictactoe/MinMaxTicTacToe.java
@@ -4,19 +4,32 @@ import org.toop.game.*;
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
-import org.toop.Main;
 
 public class MinMaxTicTacToe {
 
     private static final Logger logger = LogManager.getLogger(MinMaxTicTacToe.class);
 
+    /**
+     * This method tries to find the best move by seeing if it can set a winning move, if not, it will do a minimax.
+     */
+
     public int findBestMove(TicTacToe game) {
-        /**
-         * This method tries to find the best move by seeing if it can set a winning move, if not, it will do a minimax.
-         */
         int bestVal = -100; // set bestval to something impossible
         int bestMove = 10; // set bestmove to something impossible
 
+
+        boolean empty = true;
+        for (char cell : game.grid) {
+            if(!(cell == GameBase.EMPTY)) {
+                empty = false;
+                break;
+            }
+        }
+
+        if (empty && game.validateMove(4)) {
+            return 4;
+        }
+
         // simulate all possible moves on the field
         for (int i = 0; i < game.grid.length; i++) {
             if (game.validateMove(i)) {  // check if the move is legal here
@@ -28,9 +41,18 @@ public class MinMaxTicTacToe {
                 if (result == GameBase.State.WIN) {
                     return i; // just return right away if you can win on the next move
                 }
-                else {
-                    thisMoveValue = doMinimax(copyGame, game.movesLeft, false); // else look at other moves
+
+                for (int index = 0; index < game.grid.length; index++ ) {
+                    if (game.validateMove(index)) {
+                        TicTacToe opponentCopy = copyGame.copyBoard();
+                        GameBase.State opponentResult = opponentCopy.play(index);
+                        if (opponentResult == GameBase.State.WIN) {
+                            return index;
+                        }
+                    }
                 }
+
+                thisMoveValue = doMinimax(copyGame, game.movesLeft, false); // else look at other moves
                 if (thisMoveValue > bestVal) { // if better move than the current best, change the move
                     bestVal = thisMoveValue;
                     bestMove = i;
@@ -40,10 +62,11 @@ public class MinMaxTicTacToe {
         return bestMove; // return the best move when we've done everything
     }
 
+    /**
+     * This method simulates all the possible future moves in the game through a copy in search of the best move.
+     */
+
     public int doMinimax(TicTacToe game, int depth, boolean maximizing) {
-        /**
-         * This method simulates all the possible future moves in the game through a copy in search of the best move.
-         */
         boolean state = game.checkWin(); // check for a win (base case stuff)
 
         if (state) {
diff --git a/src/test/java/MinMaxTicTacToeTest.java b/src/test/java/MinMaxTicTacToeTest.java
index 7da0adc..19ebb25 100644
--- a/src/test/java/MinMaxTicTacToeTest.java
+++ b/src/test/java/MinMaxTicTacToeTest.java
@@ -1,76 +1,115 @@
+
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.toop.game.tictactoe.*;
+import org.toop.game.GameBase;
+import org.toop.game.tictactoe.MinMaxTicTacToe;
+import org.toop.game.tictactoe.TicTacToe;
 
 import static org.junit.jupiter.api.Assertions.*;
 
-class MinMaxTicTacToeTest {
+/**
+ * Unit tests for MinMaxTicTacToe AI.
+ */
+public class MinMaxTicTacToeTest {
 
-    // makegame makes a board situation so we can test the AI. that's it really, the rest is easy to follow id say
-    private TicTacToe makeGame(String board, int currentPlayer) {
-        TicTacToe game = new TicTacToe("AI", "Human");
-        // Fill the board
-        for (int i = 0; i < board.length(); i++) {
-            char c = board.charAt(i);
-            game.grid[i] = c;
-            if (c != '-') game.movesLeft--;
-        }
-        game.currentPlayer = currentPlayer;
-        return game;
+    private MinMaxTicTacToe ai;
+    private TicTacToe game;
+
+    @BeforeEach // called before every test is done to make it work
+    void setUp() {
+        ai = new MinMaxTicTacToe();
+        game = new TicTacToe("AI", "Human");
     }
 
     @Test
-    void testFindBestMove_AIImmediateWin() {
-        TicTacToe game = makeGame("XX-OO----", 0);
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
+    void testBestMoveWinningMoveAvailable() {
+        // Setup board where AI can win immediately
+        // X = AI, O = player
+        // X | X | .
+        // O | O | .
+        // . | . | .
+        game.grid = new char[]{
+                'X', 'X', GameBase.EMPTY,
+                'O', 'O', GameBase.EMPTY,
+                GameBase.EMPTY, GameBase.EMPTY, GameBase.EMPTY
+        };
+        game.movesLeft = 4;
+
         int bestMove = ai.findBestMove(game);
-        assertEquals(2, bestMove, "AI has to take winning move at 2");
+
+        // Ai is expected to place at index 2 to win
+        assertEquals(2, bestMove);
     }
 
     @Test
-    void testFindBestMove_BlockOpponentWin() {
-        TicTacToe game = makeGame("OO-X----", 0); // 0 = AI's turn
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
+    void testBestMoveBlocksOpponentWin() {
+        // Setup board where player could win next turn
+        // O | O | .
+        // X | . | .
+        // . | . | .
+        game.grid = new char[]{
+                'O', 'O', GameBase.EMPTY,
+                'X', GameBase.EMPTY, GameBase.EMPTY,
+                GameBase.EMPTY, GameBase.EMPTY, GameBase.EMPTY
+        };
+        game.movesLeft = 4;
+
         int bestMove = ai.findBestMove(game);
-        assertEquals(2, bestMove, "AI should block opponent win at 2");
+
+        // AI block at index 2 to continue the game
+        assertEquals(2, bestMove);
     }
 
     @Test
-    void testFindBestMove_ChooseDrawIfNoWin() {
-        TicTacToe game = makeGame("XOXOX-O--", 0);
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
+    void testBestMoveCenterPreferredOnEmptyBoard() {
+        // On empty board, center (index 4) is strongest
         int bestMove = ai.findBestMove(game);
-        assertTrue(bestMove == 6 || bestMove == 8, "AI should draw");
+
+        assertEquals(4, bestMove);
     }
 
     @Test
-    void testMinimax_ScoreWin() {
-        TicTacToe game = makeGame("XXX------", 0);
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
-        int score = ai.doMinimax(game, 5, false);
-        assertTrue(score > 0, "AI win scored positively");
+    void testDoMinimaxScoresWinPositive() {
+        // Simulate a game state where AI has already won
+        TicTacToe copy = game.copyBoard();
+        copy.grid = new char[]{
+                'X', 'X', 'X',
+                'O', 'O', GameBase.EMPTY,
+                GameBase.EMPTY, GameBase.EMPTY, GameBase.EMPTY
+        };
+
+        int score = ai.doMinimax(copy, 5, false);
+
+        assertTrue(score > 0, "AI win should yield positive score");
     }
 
     @Test
-    void testMinimax_ScoreLoss() {
-        TicTacToe game = makeGame("OOO------", 1);
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
-        int score = ai.doMinimax(game, 5, true);
-        assertTrue(score < 0, "AI loss is negative");
+    void testDoMinimaxScoresLossNegative() {
+        // Simulate a game state where human has already won
+        TicTacToe copy = game.copyBoard();
+        copy.grid = new char[]{
+                'O', 'O', 'O',
+                'X', 'X', GameBase.EMPTY,
+                GameBase.EMPTY, GameBase.EMPTY, GameBase.EMPTY
+        };
+
+        int score = ai.doMinimax(copy, 5, true);
+
+        assertTrue(score < 0, "Human win should yield negative score");
     }
 
     @Test
-    void testMinimax_ScoreDraw() {
-        TicTacToe game = makeGame("XOXOXOOXO", 0);
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
-        int score = ai.doMinimax(game, 5, true);
-        assertEquals(0, score, "Draw should be zero!");
-    }
+    void testDoMinimaxDrawReturnsZero() {
+        // Simulate a draw position
+        TicTacToe copy = game.copyBoard();
+        copy.grid = new char[]{
+                'X', 'O', 'X',
+                'X', 'O', 'O',
+                'O', 'X', 'X'
+        };
 
-    @Test
-    void testMiniMax_MultipleMoves() {
-        TicTacToe game = makeGame("-X-OX--O-", 0);
-        MinMaxTicTacToe ai = new MinMaxTicTacToe();
-        int bestMove = ai.findBestMove(game);
-        assertTrue(bestMove == 0 || bestMove == 2, "Can look at multiple moves!");
+        int score = ai.doMinimax(copy, 0, true);
+
+        assertEquals(0, score, "Draw should return 0 score");
     }
-}
+}
\ No newline at end of file