From 56a1afe1cdc4c3df685c0faf45532da3b8201631 Mon Sep 17 00:00:00 2001 From: lieght <49651652+BAFGdeJong@users.noreply.github.com> Date: Fri, 3 Oct 2025 18:34:48 +0200 Subject: [PATCH] "Fixed double sound bug" --- app/src/main/java/org/toop/app/menu/OptionsMenu.java | 9 +++------ .../main/java/org/toop/framework/audio/SoundManager.java | 3 ++- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/org/toop/app/menu/OptionsMenu.java b/app/src/main/java/org/toop/app/menu/OptionsMenu.java index a707fe7..7a67422 100644 --- a/app/src/main/java/org/toop/app/menu/OptionsMenu.java +++ b/app/src/main/java/org/toop/app/menu/OptionsMenu.java @@ -143,7 +143,7 @@ public final class OptionsMenu extends Menu { .addPostEvent(AudioEvents.GetCurrentVolume.class) .onResponse(AudioEvents.GetCurrentVolumeReponse.class, event -> { volumeSlider.setValue(event.currentVolume() * 100); - }).asyncPostEvent(); + }, true).asyncPostEvent(); volumeSlider.setShowTickLabels(true); volumeSlider.setShowTickMarks(true); volumeSlider.setMajorTickUnit(25); @@ -160,11 +160,8 @@ public final class OptionsMenu extends Menu { if (now - lastPlayed[0] >= cooldown) { lastPlayed[0] = now; - - int value = newVal.intValue(); - valueLabel.setText(String.valueOf(value)); - - new EventFlow().addPostEvent(new AudioEvents.PlayEffect("soft-button-click.wav", false)).asyncPostEvent(); +// new EventFlow().addPostEvent(new AudioEvents.clickButton()) +// .asyncPostEvent(); // TODO: creates double sound bug, WHYYY???? } valueLabel.setText(String.valueOf(newVal.intValue())); new EventFlow().addPostEvent(new AudioEvents.ChangeVolume(newVal.doubleValue()/100.0)) diff --git a/framework/src/main/java/org/toop/framework/audio/SoundManager.java b/framework/src/main/java/org/toop/framework/audio/SoundManager.java index e65e613..f7fad76 100644 --- a/framework/src/main/java/org/toop/framework/audio/SoundManager.java +++ b/framework/src/main/java/org/toop/framework/audio/SoundManager.java @@ -128,6 +128,7 @@ public class SoundManager { mediaPlayer.play(); activeMusic.add(mediaPlayer); logger.info("Playing background music: {}", ma.getFile().getName()); + logger.info("Background music next in line: {}", backgroundMusicQueue.peek().getFile().getName()); } private long playSound(String audioFileName, boolean loop) throws UnsupportedAudioFileException, LineUnavailableException, IOException { @@ -150,7 +151,7 @@ public class SoundManager { clip.start(); } - logger.info("Playing sound: {}", asset.getFile().getName()); + logger.debug("Playing sound: {}", asset.getFile().getName()); // Generate id for clip long clipId = idGenerator.nextId();